guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Add palette metadata types for US Election #241

Closed tjsilver closed 4 years ago

tjsilver commented 4 years ago

Co-authored-by: Jonathon Herbert jonathon.herbert@guardian.co.uk

What does this change?

This adds the following palette metadata to the config:

How to test

Release local version and consume in a downstream project such as Fronts Config tool. The new metadata should be available in the project.

We've tested this with Fronts locally.

How can we measure success?

Consuming projects are able to access the new metadata.

Have we considered potential risks?

Risks have been mitigated by presence of the UnknownMetadata metadata which makes this PR backwards-compatible with old versions.

jonathonherbert commented 4 years ago

RFC for emojis in tag names:

๐Ÿƒโ€โ™‚๏ธ LongRunningPalette
๐Ÿ˜ž SombrePalette
๐Ÿ•ต๏ธ InvestigationPalette
๐Ÿงจ BreakingPalette
๐ŸŽ‰ EventPalette
๐Ÿฅณ EventAltPalette

... no?

jfsoul commented 4 years ago

Worth noting here perhaps that the plan is to progressively replace DynamoLike with LongRunningPalette. Keeping both for now to support current configuration/palettes (apps only, web doesn't use DynamoLike)