rtyley
commented
3 years ago I cannot yet run with the play28 build, as there are some runtime errors in other libs when we serve the app – is there anything else that we can meaningfully test at this point?
I haven't quite got to the point of getting a compiling Ophan Play 2.8 branch yet (see https://github.com/guardian/ophan/pull/3974), so can't really check it any further at this point, but obviously will come back and fix if anything crops up - I'm happy to merge and release if that's ok with you?
jonathonherbert
What does this change?
The library is now compiled and tested against Play v2.6, v2.7, and v2.8 - see also https://github.com/guardian/facia-scala-client/pull/221 for the prior change that supported v2.7 as well as v2.6. We're looking to consume this in the Ophan project.
Note that when we say it 'supports Play version X', we really just mean that it is compiled against the compatible version of
play-jsonfor that version of Play - and as it happens, no code changes are necessary between Play v2.6, v2.7, and v2.8 (we should probably drop Play 2.6 support soon as it's EOL).