guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Handle theguardian.com short url correctly #245

Closed buck06191 closed 3 years ago

buck06191 commented 3 years ago

What does this change?

CAPI has been updated to use www.theguardian.com for short urls. I've added the appropriate regex here so that the facia client correctly removes this when getting the discussionId and added tests to check for this.

Related PRs:

How can we measure success?

Correct discussion ID passed through from new short URLs.

Have we considered potential risks?

The CAPI change has already occurred so this shouldn't be a breaking change. Even so, I've kept the handling of the old gu.com domain in.