An attempt at a fix for #249. See that issue for details.
Dev notes
Because the failure to parse the URL only occurs when we're attempting to recover the 'branding' for the snapLink (which I don't fully understand, but IIUC cannot possibly function with an invalid link!), I think we're safe to just move on and continue parsing the rest of the response. Hence we log this error, but convert to an option and continue – if anyone knows better, please say!
How to test
Do the automated tests pass, and are you satisfied that they're adequate?
Is the logging on failure adequate?
Import a local build or a snapshot of this library into a consumer, and attempt to press a snap link with an invalid link. Does the press now succeed?
What does this change?
An attempt at a fix for #249. See that issue for details.
Dev notes
Because the failure to parse the URL only occurs when we're attempting to recover the 'branding' for the snapLink (which I don't fully understand, but IIUC cannot possibly function with an invalid link!), I think we're safe to just move on and continue parsing the rest of the response. Hence we log this error, but convert to an option and continue – if anyone knows better, please say!
How to test