Add territories for Australia

davidfurey commented 3 years ago

What does this change?

This PR adds additional targeted territories to allow us to target containers at New South Wales, Queensland and Victoria, as requested by our Australian colleagues.

Once this is released:

Composer will need to bump to the latest Facia Scala Client library but should need no other changes
MAPI needs to update to the latest library and make a few minor code changes (probably just like https://github.com/guardian/mobile-apps-api/pull/1479)
Frontend needs to update to the latest library and make a few minor code changes (See https://github.com/guardian/frontend/pull/21953)
Mobile Fastly config needs to be updated to pass X-GU-Territory values for these AU regions
Frontend Fastly config needs to be updated to pass X-GU-Territory values for these AU regions

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

[ ] Tested with screen reader
[ ] Navigable with keyboard
[ ] Colour contrast passed
[ ] The change doesn't use only colour to convey meaning

rtyley commented 2 years ago

Once this is released:

Unfortunately Ophan was missed off this list of projects to update! This resulted functionality breaking on the Ophan Dashboard when the new AU-targeted containers went live today (reported in "Ophan recently published gone wonky?" from Kirsty McEwen. We've had problems a bit like this before, eg with https://github.com/guardian/ophan/pull/3575 (see the action items from retro in 2019!).

We're updating with https://github.com/guardian/ophan/pull/4411 !

davidfurey commented 2 years ago

Sorry Roberto, I didn't consider this dependency.

I've opened a PR to update the PR template to make this less likely in future - https://github.com/guardian/facia-scala-client/pull/256

Also, the JSON deserialiser is now more robust so hopefully you will not see this particular error again - https://github.com/guardian/facia-scala-client/commit/0d1ea0031baed968428f01f4b4f1a52d1e524fd6#diff-8e3aaffe5bc1dd47cdb7a982cc107606e58058dea98fc117a59ca446648fc50d

guardian / facia-scala-client