rtyley
commented
2 years ago I've made a beta release of this change as 3.3.14-beta.0 so I can check that it resolves the issue seen in https://github.com/guardian/frontend/pull/25139#issuecomment-1163407402. See also the new OphanFAPIClientTest in https://github.com/guardian/ophan/pull/4719 :
That Ophan test fails, as desired, when using the old incompatible facia-scala-client - but passes with the updated FAPI client:
What does this change?
This updates the FAPI client to be compiled against the latest version of the CAPI client, v19.0.0. Due to https://github.com/guardian/content-api-scala-client/pull/359 the latest version of the CAPI client is binary-incompatible with versions of the CAPI client prior to v19, so users of the FAPI library can not use CAPI client v19 without also using a version of the FAPI library that has been compiled with the latest version. Without updating, the users will see a
java.lang.NoSuchMethodErrorexception.See https://github.com/guardian/content-api-scala-client/pull/359#issuecomment-1171311303 for further details - although the change is binary-incompatible, the change is not source-incompatible, so updating to the latest version of CAPI and recompiling is enough to solve the problem.
I've deployed a beta version of the
facia-scala-clientto CODE Frontend, and verified that Frontend'sfacia-press, which depends on FAPI & CAPI, works correctly.I've also added a new
FaciaClientTestto both https://github.com/guardian/frontend/pull/25139/ & https://github.com/guardian/ophan/pull/4719 - these tests specifically check that this specificjava.lang.NoSuchMethodErrordoes not occur, and will fail the build if someone tries to update the FAPI or CAPI library to an incompatible combination.Deployment