search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Upgrade to play-json 3.x #300

Closed ioannakok closed 10 months ago

ioannakok commented 10 months ago

Re-raising @mkurz's PR:

It has to be raised by someone in The Guardian organisation for the build to run.

It is required for:

What does this change?

Adds fapi-client and facia-json Play 3 support.

How to test

Compiles successfully locally with the SNAPSHOT version in this frontend PR:

Deployment

rtyley commented 10 months ago

I'll review this as soon as possible, but I am off work tomorrow! I'd like to get https://github.com/guardian/facia-scala-client/pull/299 merged before merging this PR.

rtyley commented 10 months ago

This looks good, I'm going to merge and release this, though in terms of rollout to the projects that consume this library (fapi-client-... & facia-json-...) I'm not going to do any further work at this point.

There are 3 projects that have not yet upgraded to v4.0.6, see issue https://github.com/guardian/facia-scala-client/issues/301 - until content-api-client & content-api-models adopt gha-scala-library-release-workflow there's still quite a lot of risk to releasing updates - any release will require careful monitoring and synchronisation of library versions.

rtyley commented 10 months ago

This has been released as v4.0.9, using the new gha-scala-library-release-workflow 👍

Note that the initial run of the release with gha-scala-library-release-workflow failed, due to the automated-compatibility-assessment of sbt-version-policy trying to download the previous versions of the new artifacts for compatibility comparison, when, being brand new, they had never been published before.

I was able to work around this with 2d1ad72c261cbec7546703a0155e3c1f5d01991c (disabling the automated-compatibility-assessment), performing a release, and then applying 7c08a2f9eb78d11e16d73d0938ff4f9bf5fc29db, to re-enable the automated-compatibility-assessment.