guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Drop support for Scala 2.12 #317

Closed rtyley closed 3 months ago

rtyley commented 3 months ago

Continuing support for Scala 2.12 means we can't use Scala 2.13 features! If we do use Scala 2.13 features, it breaks the build (eg here, using Option.unless()):

https://github.com/guardian/facia-scala-client/actions/runs/9910387265/job/27380653158#step:5:53

[error] /home/runner/work/facia-scala-client/facia-scala-client/facia-json/src/test/scala/com/gu/facia/client/ApiClientSpec.scala:26:16: value unless is not a member of object Option
[error]         Option.unless(oldETag == taggedData.eTag)(taggedData) // simulate a Not-Modified response, if there's no change in ETag
[error]                ^

Blockers to dropping Scala 2.12 support

There's only one consumer of the facia-scala-client that has not yet upgraded to Scala 2.13:

All others are ok - they're already on Scala 2.13: