search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Drop Scala 2.12 and Play 2.7, begin partial support for Scala 3 #318

Closed rtyley closed 3 months ago

rtyley commented 3 months ago

Fixes #317, meaning that PRs like #287 can use Scala 2.13 features. Also dropping Play 2.7- Play 2.8 was end-of-life (EOL) on 31st May 2024, so dropping support for Play 2.7 seems very reasonable!

Running the tests under Scala 3 required 3690941515d0f0c3e97781f202d0bd1aa915e0a8, fixing a test so that it doesn't rely on JSON object's field order.

Consumers of facia-scala-client

All 7 consumers of the facia-scala-client library are now on Scala 2.13 (last one to upgrade was https://github.com/guardian/story-packages/pull/195!), and Play 2.8 or above, so they do not pose blockers to dropping Scala 2.12 and Play 2.7:

gu-scala-library-release[bot] commented 3 months ago

@rtyley has published a preview version of this PR with release workflow run #23, based on commit 2f129bb27f48c362829c87240146c9eaf09a041f:

8.0.1-PREVIEW.drop-scala-212-and-play-27.2024-07-24T1450.2f129bb2

Want to make another preview release? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), specifying the drop-scala-2.12-and-play-27 branch, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml --ref drop-scala-2.12-and-play-27
Want to make a full release after this PR is merged? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), leaving the branch as the default, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml
gu-scala-library-release[bot] commented 3 months ago

@rtyley has published a preview version of this PR with release workflow run #24, based on commit 3aa8aa15785799944c03c99cae006c472dca0971:

8.0.1-PREVIEW.drop-scala-212-and-play-27.2024-07-24T1515.3aa8aa15

Want to make another preview release? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), specifying the drop-scala-2.12-and-play-27 branch, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml --ref drop-scala-2.12-and-play-27
Want to make a full release after this PR is merged? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), leaving the branch as the default, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml