search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Add Europe edition to findBranding function #324

Closed emma-imber closed 1 month ago

emma-imber commented 1 month ago

What does this change?

Adds the Europe edition ID "eur" to the editions mapped over in the findBranding function. This should mean that edition branding will now be added for the Europe edition. This will enable the correct styling of labs containers and cards when the Europe edition is selected.

Tested on CODE and the EditionBranding now pulls through for "EUR" correctly:

Screenshot 2024-09-24 at 15 55 28

gu-scala-library-release[bot] commented 1 month ago

@emma-imber has published a preview version of this PR with release workflow run #35, based on commit 4707cdf8c4ee71621f2b586c1868d56260a1a727:

10.0.1-PREVIEW.eiadd-branding-eur-edition.2024-09-24T1202.4707cdf8

Want to make another preview release? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), specifying the ei/add-branding-eur-edition branch, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml --ref ei/add-branding-eur-edition
Want to make a full release after this PR is merged? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), leaving the branch as the default, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml