guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Add suppressImages to fronts tool settings #325

Closed Georges-GNM closed 1 month ago

Georges-GNM commented 1 month ago

What does this change?

Part of this ticket: we are adding a new container with two variations - one with all images suppressed and one with optional images (including cutouts). We'll use this new value in the fronts tool to indicate when a collection should show images.

How to test

Tested with a work in progress fronts tool PR.

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Deployment

gu-scala-library-release[bot] commented 1 month ago

@Georges-GNM has published a preview version of this PR with release workflow run #37, based on commit 79973a0d73a9c8b0571682311000750e5f58002a:

11.0.0-PREVIEW.gladd-suppress-images-property.2024-09-25T0940.79973a0d

Want to make another preview release? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), specifying the gl/add-suppress-images-property branch, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml --ref gl/add-suppress-images-property
Want to make a full release after this PR is merged? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), leaving the branch as the default, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml
gu-scala-library-release[bot] commented 1 month ago

@Georges-GNM has published a preview version of this PR with release workflow run #38, based on commit d2af9509a0b9a7a3e455a22c03fbd1311c1e76b2:

11.0.0-PREVIEW.gladd-suppress-images-property.2024-09-26T1303.d2af9509

Want to make another preview release? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), specifying the gl/add-suppress-images-property branch, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml --ref gl/add-suppress-images-property
Want to make a full release after this PR is merged? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), leaving the branch as the default, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml