search

guardian / facia-scala-client

Low level client for the Facia JSON API
Other
2 stars 1 forks source link

Remove suppress images prop from fronts tool settings #326

Closed Georges-GNM closed 4 weeks ago

Georges-GNM commented 1 month ago

What does this change?

Moves the suppressImages value from a collection's frontsToolSettings to the collection itself - this is now the preferred approach to ensure full functionality of suppressing images on a container.

Will be used by the fronts tool via this PR

gu-scala-library-release[bot] commented 1 month ago

@Georges-GNM has published a preview version of this PR with release workflow run #40, based on commit 1b3d50f296e1075db211b942b1928b379e4bd051:

12.0.0-PREVIEW.glmove-suppress-images-prop.2024-10-01T1416.1b3d50f2

Want to make another preview release? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), specifying the gl/move-suppress-images-prop branch, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml --ref gl/move-suppress-images-prop
Want to make a full release after this PR is merged? Click 'Run workflow' in the [GitHub UI](https://github.com/guardian/facia-scala-client/actions/workflows/release.yml), leaving the branch as the default, or use the [GitHub CLI](https://cli.github.com/) command: gh workflow run release.yml