crosswords: Not managing separators for grouped clues with more then 2 entries

scottp719 commented 9 years ago

http://www.theguardian.com/crosswords/cryptic/26666

This crossword has a grouped clue with 8 words over 4 linked (across and down), we are only displaying the first separator in 2 down and missing all others.

User feedback has come in regarding this

scottp719 commented 9 years ago

We also need to display the order the clues need to be entered. I.e. in R2 you get this:

In NGW you see:

OliverJAsh commented 9 years ago

This happens because all of the separators data is on the master clue, 2-down. Here is the group:

[
  {
    "id": "10-across",
    "number": 10,
    "humanNumber": "10",
    "direction": "across",
    "position": {
      "x": 5,
      "y": 3
    },
    "separatorLocations": {},
    "length": 9,
    "clue": "See 2",
    "group": [
      "2-down",
      "10-across",
      "23-down",
      "21-across"
    ],
    "solution": "THEROMANS"
  },
  {
    "id": "21-across",
    "number": 21,
    "humanNumber": "21",
    "direction": "across",
    "position": {
      "x": 1,
      "y": 11
    },
    "separatorLocations": {},
    "length": 9,
    "clue": "See 2",
    "group": [
      "2-down",
      "10-across",
      "23-down",
      "21-across"
    ],
    "solution": "DONEFORUS"
  },
  {
    "id": "2-down",
    "number": 2,
    "humanNumber": "2,10,23,21across",
    "direction": "down",
    "position": {
      "x": 3,
      "y": 0
    },
    "separatorLocations": {
      ",": [
        4,
        8,
        11,
        17,
        21,
        25,
        28
      ]
    },
    "length": 8,
    "clue": " Excuse me? Did some old people at any time cause our ruin? That's a funny revolutionary line (4,4,3,6,4,4,3,2)",
    "group": [
      "2-down",
      "10-across",
      "23-down",
      "21-across"
    ],
    "solution": "WHATHAVE",
    "format": "4,4,3,6,4,4,3,2"
  },
  {
    "id": "23-down",
    "number": 23,
    "humanNumber": "23",
    "direction": "down",
    "position": {
      "x": 13,
      "y": 11
    },
    "separatorLocations": {},
    "length": 4,
    "clue": "See 2",
    "group": [
      "2-down",
      "10-across",
      "23-down",
      "21-across"
    ],
    "solution": "EVER"
  }
]

This feels like we are receiving the wrong data: shouldn't the separator locations appear on the corresponding clues/entries?

guardian / frontend

crosswords: Not managing separators for grouped clues with more then 2 entries #10364