guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.83k stars 556 forks source link

Comment functionality broken on HTTPS sections in Firefox 44+ #12012

Closed OliverJAsh closed 8 years ago

OliverJAsh commented 8 years ago

Steps to reproduce:

  1. Go to https://www.theguardian.com/crosswords/quick/14282
  2. Refresh to activate the service worker
  3. Sign in
  4. Open up the network panel
  5. Search for a request beginning with https://discussion.theguardian.com/discussion-api/profile/me

Expected: This request should return 200 and the response should have a status of “success”.

Actual: The request returns 200 and the response has a status of “error”.

image

After chats with Ben Kelly who works on the service workers implementation inside of Firefox, we discovered that there is a bug on their end. When making a JS request (<script> i.e. JSONP), Firefox’s service worker will forward the request but drop cookies if the request is cross origin. The expected behaviour is it should send the cookies in the forwarded request. This bug can be tracked at https://bugzilla.mozilla.org/show_bug.cgi?id=1248994.

Fix to follow.

TBonnin commented 8 years ago

Nice catch @OliverJAsh