search

guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 556 forks source link

Some old liveblogs are still served by frontend (amp and regular) #25309

Closed ioannakok closed 7 months ago

ioannakok commented 2 years ago

See examples: https://www.theguardian.com/football/2010/feb/28/tottenham-hotspur-everton-live https://www.theguardian.com/sport/2013/jun/17/miami-heat-san-antonio-spurs-nba-finals-live https://www.theguardian.com/politics/blog/2014/mar/12/ed-milibands-speech-ruling-out-automatic-eu-referendum-politics-live-blog

Example: https://amp.theguardian.com/lifeandstyle/2022/jul/28/the-guardian-thursday-quiz-general-knowledge-topical-news-trivia-66-kate-bush

jlieb10 commented 2 years ago

These articles don't follow the URL pattern we require for DCR rendering liveblogs https://github.com/guardian/frontend/blob/main/article/conf/routes#L22

These are being rendered by the article controller instead of the liveblog controller

Logic here: https://github.com/guardian/frontend/blob/main/article/app/services/dotcomponents/ArticlePicker.scala#L29-L34

rhiannareechaye commented 1 year ago

We are deprioritising this ticket by 'closing a not planned' - this won't delete the ticket and it will be searchable if the issue crops up again. Unfortunately we have over 130 health tickets to address in the web team and we can't address them all. With so many tickets we are potentially missing things that are high-impact so we're reorganising.