guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.84k stars 554 forks source link

Evaluate who can access `admin` #26413

Open georgeblahblah opened 1 year ago

georgeblahblah commented 1 year ago

Currently, anyone with a guardian.co.uk google login can access the admin app ^1.

Given that the admin app exposes features and settings which can have unintended consequences, it might be worth

  1. Defining which Google groups should have access to admin
  2. Restricting certain routes to a subset of those groups

The motivation for this was raised by @SiAdcock

SiAdcock commented 1 year ago

Thanks for starting this conversation @georgeblahblah

Use case 1: Currently, anyone can edit our ads.txt. This has implications for:

Use case 2: Currently, anyone can disable commercial third party integrations via the switchboard. The consequences of doing this are difficult to imagine. It's hoped that only people well-versed in these integrations and their relative importance would consider doing this, but at the moment there is no way of enforcing this.