Use service account for connecting to Google Ad Manager API

Jakeii commented 1 month ago

What is the value of this and can you measure success?

Current authentication is tied to a user account of someone on the commercial team.

If for whatever reason their account is removed (when they leave) or they no longer need access to GAM (by changing teams) the credentials stop working and they need to be replaced.

This has happend a few times over the years, by changing to a service account we can stop this mildly inconvenient thing happening now and again!

What does this change?

Replace client id/secret and refresh token with a service account JSON file (still stored in parameter store).

The SDK will only accept a file path so the token is written as a temporary file and then cleaned up using the stop hooks.

Checklist

[x] Tested locally, and on CODE if necessary
[ ] Will not break dotcom-rendering
[ ] Will not break our database – if updating CAPI, updated and committed the database files
[ ] Meets our accessibility standards
- [ ] Tested with screen reader
- [ ] Navigable with keyboard
- [ ] Colour contrast passed

github-actions[bot] commented 1 month ago

Deploy build 2115 of `dotcom:frontend-all` to CODE

All deployment options

- [Deploy build 2115 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=2115&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 2115 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=2115&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 4 weeks ago

Seen on ADMIN-PROD (merged by @Jakeii 12 minutes and 5 seconds ago)

Check your changes on www.theguardian.com ✔️
Keep an eye on the deploy dashboard&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉

prout-bot commented 4 weeks ago

Seen on FRONTS-PROD (merged by @Jakeii 13 minutes and 9 seconds ago)

Check your changes on www.theguardian.com ✔️
Keep an eye on the deploy dashboard&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉

guardian / frontend