Fix `CuratedContent` type mismatch

guardian / frontend

The Guardian DotCom.

https://theguardian.com

Other

5.82k stars 556 forks source link

Fix `CuratedContent` type mismatch #27217

Closed mxdvl closed 1 month ago

mxdvl commented 1 month ago

What is the value of this and can you measure success?

Able to run the main branch

What does this change?

Use the pressed.CuratedContent explicitely, to ensure there is an overlap with the PressedPage type

Checklist

[X] Tested locally, and on CODE if necessary
[X] Will not break dotcom-rendering
[X] Will not break our database – if updating CAPI, updated and committed the database files
[X] Meets our accessibility standards
- [ ] Tested with screen reader
- [ ] Navigable with keyboard
- [ ] Colour contrast passed

github-actions[bot] commented 1 month ago

Deploy build 2098 of `dotcom:frontend-all` to CODE

All deployment options

- [Deploy build 2098 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=2098&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 2098 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=2098&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 1 month ago

Seen on ADMIN-PROD (merged by @mxdvl 10 minutes and 48 seconds ago)

Check your changes on www.theguardian.com ✔️
Keep an eye on the deploy dashboard&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉