guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.82k stars 556 forks source link

Only show the crossword-banner ad if there's a comments section #27242

Closed emma-imber closed 1 week ago

emma-imber commented 2 weeks ago

What does this change?

At the moment we're showing a crossword-banner ad and a merch high ad between the 740px and 1300px breakpoints on crosswords. This is fine for crosswords with comments, as the comments section acts as a buffer between the two ads. However, not all crosswords are commentable, so for those we shouldn't show any crossword-banner ad as it doesn't look great.

Screenshots

Before After
Screenshot 2024-06-20 at 17 13 01 Screenshot 2024-06-20 at 17 13 09
prout-bot commented 1 week ago

Seen on ADMIN-PROD (merged by @emma-imber 11 minutes and 3 seconds ago)

prout-bot commented 1 week ago

Seen on FRONTS-PROD (merged by @emma-imber 12 minutes and 7 seconds ago)