guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.82k stars 556 forks source link

Add `hasLiveBlogTopAd` to page config #27259

Closed Jakeii closed 6 days ago

Jakeii commented 1 week ago

What does this change?

Add new LiveBlogTopSponsorship DFP job to set hasLiveBlogTopAd on the page config that will be used by DCR to conditionally render the liveblog-top slot.

Namely the line items need to:

Screenshots

Screenshot 2024-06-26 at 15 58 06
github-actions[bot] commented 1 week ago

Deploy build 2300 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 2300 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=2300&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 2300 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=2300&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

Jakeii commented 6 days ago

nice one just couple notes

Cheers

prout-bot commented 6 days ago

Seen on FRONTS-PROD, ADMIN-PROD (merged by @Jakeii 50 minutes and 44 seconds ago)