guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.82k stars 556 forks source link

Remove `trackNavBetweenImages` function call from hosted content gallery #27264

Closed arelra closed 1 week ago

arelra commented 1 week ago

What is the value of this and can you measure success?

We had a bug report that hosted content galleries pagination feature was not updating the page number or the URL hash.

Hosted content is full-page advertiser content. This content is created by advertisers and hosted by the Guardian. Hosted content paths begin with /advertiser-content.

An example of a hosted content gallery:

https://www.theguardian.com/advertiser-content/microsoft-ai-for-earth/meet-the-changemakers

What does this change?

This changes removes calls to the function trackNavBetweenImages that no longer exists which caused an exception to be thrown. This appears to be a regression introduced in https://github.com/guardian/frontend/pull/27188

prout-bot commented 1 week ago

Seen on FRONTS-PROD, ADMIN-PROD (merged by @arelra 18 minutes and 31 seconds ago)