Remove SASS warnings - Githubissues

guardian / frontend

The Guardian DotCom.

https://theguardian.com

Other

5.84k stars 555 forks source link

Remove SASS warnings #27275

Closed domlander closed 3 months ago

domlander commented 3 months ago

Closes https://github.com/guardian/dotcom-rendering/issues/11738

What is the value of this and can you measure success?

Less noise in the terminal. Easier to upgrade in the future

What does this change?

Removes SASS warnings by using the following codemods:

PS I've gone through every line of these changes but I do not expect the reviewer to!

Checklist

[x] Tested locally, and on CODE if necessary
[ ] Will not break dotcom-rendering
[ ] Will not break our database – if updating CAPI, updated and committed the database files
[ ] Meets our accessibility standards
- [ ] Tested with screen reader
- [ ] Navigable with keyboard
- [ ] Colour contrast passed

github-actions[bot] commented 3 months ago

Deploy build 2317 of `dotcom:frontend-all` to CODE

All deployment options

- [Deploy build 2317 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=2317&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 2317 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=2317&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 3 months ago

Seen on FRONTS-PROD (merged by @domlander 13 minutes and 7 seconds ago)

Check your changes on www.theguardian.com ✔️
Keep an eye on the deploy dashboard&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉