guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.82k stars 556 forks source link

Ensure live updates are linked to football sportsblog #27278

Closed DanielCliftonGuardian closed 3 days ago

DanielCliftonGuardian commented 4 days ago

What is the value of this and can you measure success?

Ensures match report and live updates tabs are displayed with links Resolves https://github.com/guardian/dotcom-rendering/issues/11762

What does this change?

Removes failing date checking which I think is unnecessary

Screenshots

Before After
before after

Checklist

github-actions[bot] commented 4 days ago

Deploy build 2324 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 2324 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=2324&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 2324 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=2324&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

DanielCliftonGuardian commented 4 days ago

Have we tested that this always points to the correct match? Is there a risk that we wrongly link a sport blog to the wrong match?

This is actually caused by the date comparison comparing UTC with local date time BST. So a match kicking off at 23:00 will be false. I'll refactor the check.

prout-bot commented 3 days ago

Seen on ADMIN-PROD (merged by @DanielCliftonGuardian 12 minutes and 2 seconds ago)

prout-bot commented 3 days ago

Seen on FRONTS-PROD (merged by @DanielCliftonGuardian 12 minutes and 8 seconds ago)