guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.82k stars 556 forks source link

Show total images for “next” request in DCR #27287

Closed mxdvl closed 2 days ago

mxdvl commented 3 days ago

What is the value of this and can you measure success?

We can show a proper counter in DCR Lightbox.

What does this change?

Add an total field which contains the total number of images for an endpoint.

Screenshots

image

Checklist

github-actions[bot] commented 3 days ago

Deploy build 2341 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 2341 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=2341&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 2341 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=2341&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 2 days ago

Seen on FRONTS-PROD, ADMIN-PROD (merged by @mxdvl 12 minutes and 1 second ago)

mxdvl commented 2 days ago

Actually, the total is not taking into account the direction, but rather the entirety of the search results for the given tag… see https://github.com/guardian/content-api/issues/2902