Add audio data to main media for audio articles

guardian / frontend

The Guardian DotCom.

https://theguardian.com

Other

5.85k stars 555 forks source link

Add audio data to main media for audio articles #27501

Closed oliverabrahams closed 1 month ago

oliverabrahams commented 2 months ago

What is the value of this and can you measure success?

This will allow us to add an audio player to dcr for audio articles. By passing the audio main media element through FE to dcr

What does this change?

This adds the Audio files to the main media element for audio articles. It passes the audio files and the associated fields if there is no html field or if the other functions are not returning in the get or else.

Screenshots

Before	After

Checklist

[x] Tested locally, and on CODE if necessary
[ ] Will not break dotcom-rendering

github-actions[bot] commented 2 months ago

Deploy build 3096 of `dotcom:frontend-all` to CODE

All deployment options

- [Deploy build 3096 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3096&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3096 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3096&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 1 month ago

Seen on FRONTS-PROD (merged by @oliverabrahams 12 minutes and 6 seconds ago)

Check your changes on www.theguardian.com ✔️
Keep an eye on the deploy dashboard&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉