search

guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.84k stars 554 forks source link

Remove Prebid Bidder Performance in Admin Frontend tools #27506

Open deedeeh opened 5 days ago

deedeeh commented 5 days ago

What does this change?

This PR removes the Prebid Bidder Performance from Performance section in Commercial tools which is found in admin Frontend tools.

The Commercial team is tidying up the Commercial tools in admin page and this is the first step towards it.

Related PRs https://github.com/guardian/Prebid.js/pull/159 and https://github.com/guardian/platform/pull/1625

The merging order for the PRs as follows https://github.com/guardian/frontend/pull/27506#discussion_r1781452351

Screenshots

Before After
before after

Checklist

github-actions[bot] commented 5 days ago

Deploy build 3005 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3005 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3005&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3005 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3005&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

deedeeh commented 5 days ago

Nice! I think we can also now get rid of the dateLineCharts.scala.html file as it looks like only the TeamKPIController was referencing it

Ah yes we can do that! Thanks for pointing it out 👍🏼