guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

Remove `scrollable/highlights` container layout definition for frontend #27513

Closed cemms1 closed 2 weeks ago

cemms1 commented 1 month ago

What is the value of this and can you measure success?

When a front falls back to frontend instead of DCR, we're getting some wacky layouts for scrollable/highlights. Ideally we wouldn't render this container at all but as a first step we can let it fall back to displaying as a fixed/slow/small-iv container as with other containers without definitions.

What does this change?

Removes the layout definition for the scrollable/highlights container and lets it fall back to the default value instead (fixed-4)

Screenshots

Checklist

github-actions[bot] commented 1 month ago

Deploy build 3026 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3026 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3026&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3026 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3026&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

github-actions[bot] commented 3 weeks ago

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

github-actions[bot] commented 2 weeks ago

This PR was closed because it has been stalled for 3 days with no activity.