guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

Pass collection level on the Frontend config model #27574

Closed abeddow91 closed 1 week ago

abeddow91 commented 3 weeks ago

[!NOTE] This PR needs this DCR PR to be merged first: https://github.com/guardian/dotcom-rendering/pull/12828

What does this change?

Separates the collection level from the rest of the metadata tags onto its own property on the collection config. Currently, all tags come through as one metadata object to DCR but this primarily used for container palette tags by the platform and requires enhancement there to extract the collection level from the other container tags. This brings that transformation closer to the source.

Testing

On code, we can now see the collection level property come through in the pressed lite json for a container with a container level tag:

image

Checklist

github-actions[bot] commented 3 weeks ago

Deploy build 3258 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3258 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3258&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3258 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3258&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 1 week ago

Seen on ADMIN-PROD (created by @abeddow91 and merged by @cemms1 13 minutes and 7 seconds ago)

prout-bot commented 1 week ago

Seen on FRONTS-PROD (created by @abeddow91 and merged by @cemms1 14 minutes and 11 seconds ago)