search

guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

Turn off AMP for certain tagged content #27584

Closed SiAdcock closed 2 weeks ago

SiAdcock commented 3 weeks ago

What is the value of this and can you measure success?

We would like to temporarily disable AMP for contents with the following tags over the post-election period:

We also want to permanently disable content with the following tag:

What does this change?

Update shouldAmplify logic to turn off content with certain tags in AMP

We use this mechanism in addition to the one used in dotcom-rendering, although both are necessary as they do different things.

The mechanism in dotcom-rendering avoids adding an amphtml link to the final markup, and also ensures AMP pages with unsupported elements return a 415 (not supported) error.

This change avoids making an unnecessary request to DCR and associated redirect to canonical page.

See guardian/dotcom-rendering#12776, guardian/dotcom-rendering#12771, guardian/dotcom-rendering#12664)

github-actions[bot] commented 3 weeks ago

Deploy build 3218 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3218 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3218&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3218 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3218&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 2 weeks ago

Seen on ADMIN-PROD (merged by @SiAdcock 12 minutes and 57 seconds ago)

prout-bot commented 2 weeks ago

Seen on FRONTS-PROD (merged by @SiAdcock 13 minutes and 7 seconds ago)