guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

Make feature switches flaggable as 'high impact', with client-side warnings when disabling #27600

Closed i-hardy closed 1 week ago

i-hardy commented 1 week ago

What does this change?

This adds the ability to flag a feature switch as 'high impact'. This will display a short warning message in the switchboard client side, as well as a longer message in a native browser confirm prompt when attempting to disable the switch.

What is the value of this and can you measure success?

Some switches have a fairly minor impact if disabled, whereas others present a major financial or technical risk if turned off, but presently there is no way to distinguish them and no safeguards against accidentally disabling something dangerous. This feature makes it much clearer when changing a switch state carries high organisational risk and prevents accidentally disabling the wrong thing.

Screenshots

Before After
Screenshot 2024-11-13 at 12-21-49 Switchboard Screenshot 2024-11-13 at 12-21-20 Switchboard

Screenshot 2024-11-13 at 12 23 19

Screenshot 2024-11-13 at 12 23 38

Checklist

github-actions[bot] commented 1 week ago

Deploy build 3263 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3263 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3263&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3263 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3263&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 1 week ago

Seen on ADMIN-PROD (merged by @i-hardy 19 minutes and 34 seconds ago)

prout-bot commented 1 week ago

Seen on FRONTS-PROD (merged by @i-hardy 19 minutes and 55 seconds ago)