guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

[fairground] Suppress images if indicated by the collection config #27601

Closed Georges-GNM closed 1 week ago

Georges-GNM commented 1 week ago

What is the value of this and can you measure success?

Part of the fairground project, resolves this ticket.

What does this change?

Makes use of the suppress images property getting sent in the config. This gets passed through to end up getting used in the PressedDisplaySettings to determine the imageHide value.

 Testing

This logic gets executed when a page gets pressed, so the only way to test is to deploy to code, create a container with a suppress images option, launch it from the v2 fronts tool, and then you should be able to verify that images get hidden.

Screenshots

A collection with images suppressed on DCR:

image

the corresponding collection in the fronts tool config:

image

Checklist

github-actions[bot] commented 1 week ago

Deploy build 3267 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3267 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3267&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3267 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3267&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 1 week ago

Seen on FRONTS-PROD, ADMIN-PROD (merged by @Georges-GNM 12 minutes and 8 seconds ago)