guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

Provide DCAR JSON For Galleries #27612

Closed JamieB-gu closed 1 week ago

JamieB-gu commented 1 week ago

Currently, when requesting JSON for a gallery, forceDCR is ignored. This is because the request has to be categorised as a "remote render" for DCAR JSON to be provided. However, this JSON is provided by frontend, not DCAR, so it's not accurate to call it a "remote render".

This change creates a separate case, apart from the "remote render" logic, to handle DCAR JSON for galleries.

Note: Prior to #27556 it would still have been possible to get DCAR JSON, because forceDCR would have categorised the request as a "remote render". However, as mentioned above, this is not a "remote render", so the solution is to make the change here rather than reverting or altering that PR.

github-actions[bot] commented 1 week ago

Deploy build 3299 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3299 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3299&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3299 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3299&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.

prout-bot commented 1 week ago

Seen on ADMIN-PROD (merged by @JamieB-gu 12 minutes and 8 seconds ago)

prout-bot commented 1 week ago

Seen on FRONTS-PROD (merged by @JamieB-gu 13 minutes and 13 seconds ago)