guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.85k stars 555 forks source link

Adjust logic for deriving collectionLevel from metadata #27624

Closed cemms1 closed 3 days ago

cemms1 commented 3 days ago

What does this change?

When testing the gl/collection-level branch on CODE, it wasn't deriving the "Primary" collectionLevel value as expected.

This PR ensures that when config.metadata is None (ie the container has no tags set), it is treated appropriately and returns "Primary" rather than None

This PR also prevents the "Secondary" containerLevel from being applied to non beta collections, which is probably safer for now

github-actions[bot] commented 3 days ago

Deploy build 3328 of dotcom:frontend-all to CODE

All deployment options - [Deploy build 3328 of `dotcom:frontend-all` to CODE](https://riffraff.gutools.co.uk/deployment/deployAgain?project=dotcom%3Afrontend-all&build=3328&stage=CODE&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 3328 to CODE by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=dotcom%3Afrontend-all&build=3328&stage=CODE&updateStrategy=MostlyHarmless) - [What's on CODE right now?](https://riffraff.gutools.co.uk/deployment/history?projectName=dotcom%3Afrontend-all&stage=CODE)

From guardian/actions-riff-raff.