guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.83k stars 555 forks source link

Top margin too large on inline images #3863

Closed paulrobertlloyd closed 10 years ago

paulrobertlloyd commented 10 years ago

Inline images (.img--inline) should have a top margin of 3px, but this value is overridden by the default value for .img, which is 20px. The CSS for .inline--img appears on line 15, whereas the base styles for .img appear later (on lines 74 and 161). So to fix this bug, the order in which images styles are loaded will need to be changed. (Tried to fix this myself, but soon got lost in a maze of CSS!)

Here is the incorrect appearance: screen shot 2014-04-10 at 16 05 04

And here is how it should look: screen shot 2014-04-10 at 16 10 20

phamann commented 10 years ago

PDD!

paulrobertlloyd commented 10 years ago

As seen on this page: http://www.theguardian.com/football/blog/2014/apr/10/champions-league-semi-finals-how-teams-compare

mattosborn commented 10 years ago

fixed by #3901