search

guardian / frontend

The Guardian DotCom.
https://theguardian.com
Other
5.83k stars 556 forks source link

Supporting membership event clearing rest of content and not interactive #9930

Closed rcrphillips closed 8 years ago

rcrphillips commented 9 years ago

http://www.theguardian.com/politics/2015/jul/24/did-you-hear-the-one-about-jeremy-corbyn-twitter-corbynjokes

Also, the links in the element are not working.

Apols if this is for the Membership team?

screen shot 2015-07-24 at 17 13 13
OliverJAsh commented 9 years ago

Is this an embedded piece of content?

OliverJAsh commented 9 years ago

Could be one for @uplne, @Calanthe, or @davidrapson

davidrapson commented 9 years ago

@OliverJAsh The Membership event embed comes from us, but it looks like this is more down to the tweets not clearing:

screen shot 2015-07-24 at 17 18 58

OliverJAsh commented 9 years ago

If I add clearing to it using DevTools, it doesn't fix the problem.

On Mon, 27 Jul 2015 at 10:39 David Rapson notifications@github.com wrote:

@OliverJAsh https://github.com/OliverJAsh The Membership event embed comes from us, but it looks like this is more down to the tweets not clearing:

[image: screen shot 2015-07-24 at 17 18 58] https://cloud.githubusercontent.com/assets/123386/8902836/a4c79ef2-344b-11e5-8f00-cba89809784b.png

— Reply to this email directly or view it on GitHub https://github.com/guardian/frontend/issues/9930#issuecomment-125146910.

Visit theguardian.com. On your mobile and tablet, download the Guardian iPhone and Android apps theguardian.com/guardianapp and our tablet editions theguardian.com/editions. Save up to 57% by subscribing to the Guardian and Observer - choose the papers you want and get full digital access. Visit subscribe.theguardian.com

This e-mail and all attachments are confidential and may also be privileged. If you are not the named recipient, please notify the sender and delete the e-mail and all attachments immediately. Do not disclose the contents to another person. You may not use the information for any purpose, or store, or copy, it in any way. Guardian News & Media Limited is not liable for any computer viruses or other material transmitted with or as part of this e-mail. You should employ virus checking software.

Guardian News & Media Limited is a member of Guardian Media Group plc. Registered Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP. Registered in England Number 908396

scottp719 commented 8 years ago

@uplne @Calanthe - is this a commercial job or one for sustain?

davidrapson commented 8 years ago

@ScottPainterGNM I'll pick this one up, save it sitting stale.

scottp719 commented 8 years ago

Cheers @davidrapson - you get a :gem: !

davidrapson commented 8 years ago

Had a bit of a look into this. In the reported case the embed has been removed ,however we are planning on removing that particular embed completely as in practice we are using a different and preferred embed via merchandising components. So I'm going to close this issue as the embed itself it going soon. Hope that made some sense.