search

guardian / gibbons

Cleanup monkeys for the CAPI API keys table
0 stars 0 forks source link

Updating inaccurate copy for key deletion email #17

Closed rowannekabalan closed 3 years ago

rowannekabalan commented 3 years ago

What does this change?

Updates the email copy sent to users to inform them their keys have been deleted, as it incorrectly stated that keys get deleted when they are not used for 30 months, when in fact they get deleted if the user does not respond to the key extension email, regardless of whether they use their key(s) or not.

How to test

Change is pretty straightforward, there is probably no need to test it unless you really want to :D In which case, you can try creating a key and manually changing the creation date to an old date, then wait for the email lambda to run (it does every 24 hours), or attempt to run the lambda manually. (If you think there is a better way to test this -which there probably is- please feel free to suggest.)

rowannekabalan commented 3 years ago

Looks good. Might be worth paging @davidfurey as he had thoughts on the email copy from before. It's also worth updating the email copy for the initial email whilst we're here:

https://github.com/guardian/gibbons/blob/master/src/main/twirl/reminder.scala.html

Thanks @Fweddi! Done. I think I'll page David on the dev channel in case he has any suggestions.

davidfurey commented 3 years ago

This is much clearer, thank you Rowanne.