IMAGEDAM-1400 - Fixing 'Social Media' and 'R&M Photographer - staff' templates

[Conalb97]

What does this change?

Both the Social Media and R&M Photographer - staff templates were not working as they could not be applied.

This was due to the leases for these templates being undefined as they did not have leases associated with them.

The solution was to add an if-statement on line 153 where the undefined error was occurring, that way a lease is not attempted to be accessed if the template does not contain any.

## How should a reviewer test this change? Add the following to application.conf, to be able to select the 'Social Media' template: metadata.templates = [ { templateName: "Social Media" usageRights: { category: "social-media" restrictions: "SOCIAL MEDIA - Usage requires approval by a Senior Editor" } metadataFields: [ { name: "specialInstructions" value: "Approval needed from a senior editor" resolveStrategy: "replace" } ] } ] To reproduce the issue this PR is fixing: Upload a new image to the grid and select the 'Social Media' template from the templates dropdown. Click the apply button for the template to be applied. The apply button will change to have a 'clock' icon within the button. Attempting to click it now will not work and the changes from the template won't be saved.  To confirm the fix is working: Upload a new image to the grid and select the 'Social Media' template from the templates dropdown. Click the apply button for the template to be applied. The apply button will briefly change to have a 'clock' icon within the button and the changes from the template will be saved. 

How can success be measured?

The Social Media and R&M Photographer - staff templates can be successfully applied.

Who should look at this?

@guardian/digital-cms

Tested? Documented?

• [x] locally by committer
• [ ] locally by Guardian reviewer
• [x] on the Guardian's TEST environment
• [ ] relevant documentation added or amended (if needed)

[prout-bot]

Seen on image-loader, usage, kahuna, media-api (created by @Conalb97 and merged by @paperboyo 11 minutes and 56 seconds ago) Please check your changes!

[prout-bot]

Seen on collections, cropper (created by @Conalb97 and merged by @paperboyo 12 minutes and 2 seconds ago) Please check your changes!

[prout-bot]

Seen on metadata-editor, leases (created by @Conalb97 and merged by @paperboyo 12 minutes and 6 seconds ago) Please check your changes!

[prout-bot]

Seen on auth, thrall (created by @Conalb97 and merged by @paperboyo 12 minutes and 11 seconds ago) Please check your changes!