Closed Conalb97 closed 11 months ago
Hi, Thanks for that. Eminently sensible, I think.
One tiny thing: I think we should now remove the duplicated/redundant now second instance of “Collections” (highlighted below):
Hi, Thanks for that. Eminently sensible, I think.
One tiny thing: I think we should now remove the duplicated/redundant now second instance of “Collections” (highlighted below):
Thanks Mat for the feedback, will update the PR now
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, media-api, kahuna (created by @Conalb97 and merged by @twrichards 10 minutes and 53 seconds ago) Please check your changes!
Seen on collections (created by @Conalb97 and merged by @twrichards 11 minutes ago) Please check your changes!
What does this change?
To raise visibility and awareness of Collections, the word 'Collections' has been added next to the Collections icon in the navigation. The behaviour of this label must match the existing labels and as such is resizeable, so the text is removed when the user shrinks the page.
How should a reviewer test this change?
These changes can be tested by confirming that when landing on BBC Images tester can clearly see the link to Collections in the navigation, in the same style as 'Show preview' and 'Show info panel' buttons. Clicking on the icon or the word 'Collections' opens up the Collections panel.
On smaller breakpoints where there isn't room for the full button just the icon should display - consistent with 'Show preview' and 'Show info panel' buttons which just display as icons.
Who should look at this?
@guardian/digital-cms
Tested? Documented?