search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 120 forks source link

move 'reapable' eligibility logic into `common-lib` (along with supporting classes) #4143

Closed twrichards closed 11 months ago

twrichards commented 11 months ago

https://trello.com/c/DrGAH8Y0/893-turn-on-the-reaper

Similar to what was done as part of the temporary #4066 (reverted in #4097) we need (in upcoming PR) to query for reapabality in thrall and as such this PR moves the 'reapable' eligiblity logic from media-api to common-lib along with supporting classes. It's in its own PR to make it easier to review.

This should be a no-op, and to test you can use the is:reapable search before and after this branch is deployed.

IMPORTANT

This involves moving the persistence.identifier and persistence.collections from media-api.conf up to common.conf otherwise all microservices (except media-api) will fail to start. This has already been done at the Guardian (both TEST and PROD) a while back as part of #4066 (and left in common).

prout-bot commented 11 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 26 minutes and 23 seconds ago) Please check your changes!