search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 119 forks source link

Imagedam 1564 reapable eligibility conf #4172

Closed abdelrahmansd closed 8 months ago

abdelrahmansd commented 9 months ago

What does this change?

reads ReapableEligibility trait implementation from configuration if it exists reaper.provider

## How should a reviewer test this change? without defining the`reaper.provider` configuration it should behave the same as the current implementation with defining the`reaper.provider` configuration i.e. reaper.provider = "com.gu.mediaservice.lib.CustomReaper" it should use this implementation of the ReapableEligibility trait

How can success be measured?

Who should look at this?

Tested? Documented?

twrichards commented 8 months ago

Will also need a rebase onto main (which can be done in the UI at the bottom of the PR).

prout-bot commented 8 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (created by @abdelrahmansd and merged by @twrichards 9 minutes and 52 seconds ago) Please check your changes!