guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 119 forks source link

remove google analytics code from Kahuna #4173

Closed dblatcher closed 8 months ago

dblatcher commented 9 months ago

What does this change?

Removes the code for Google Analytics:

The account it used was turned off in July and the data wasn't being used before then, see https://trello.com/c/MvsOLUwA/1435-remove-ga-from-grid.

How should a reviewer test this change?

Runs locally without any noticable change (there was no googleTrackingId in the DEV config, so the GA scripts were not rendered, but the the line in the config script (visible in view-source:https://media.local.dev-gutools.co.uk/) will be gone.

When deployed to CODE, the should work as before, but with no googleTrackingId loaded into config and no https://www.google-analytics.com/analytics.js script

How can success be measured?

Still works as before, less redundant code.

Who should look at this?

Tested? Documented?

prout-bot commented 8 months ago

Seen on auth, usage, image-loader, thrall, leases, cropper, collections, media-api, kahuna (created by @dblatcher and merged by @twrichards 8 minutes and 50 seconds ago) Please check your changes!

prout-bot commented 8 months ago

Seen on metadata-editor (created by @dblatcher and merged by @twrichards 9 minutes and 8 seconds ago) Please check your changes!