Change upload description control to have non-funny prompt

AndyKilmory commented 8 months ago

What does this change do?

Changes the prompt in the description field on the Upload page.

When testing the addition of keywords to the upload page BBC BA spotted the 'funny descriptions' that appear if the upload file name is deleted in the description field. Consenus in the team was that these personalised messages were a bit inappropriate and should be replaced by something less likely to offend.

How should a reviewer test this change?

Go to recent uploads and upload a file - delete the content of the description field and review the eg. propmt that is presented it should read 'eg Give some context about the image including who, what, where, when and why'

Tested? Documented?

[ ] locally by committer
[ ] locally by Guardian reviewer
[ ] on the Guardian's TEST environment
[ ] relevant documentation added or amended (if needed)

paperboyo commented 8 months ago

less likely to offend

O tempora, o mores! 😢

Sad, but fine, IMHO, so: 👍. Whatever makes people write better captions, wins.

AndyKilmory commented 8 months ago

Many thanks Mateusz – sad to see them go – they made me smile at least!

Andy Downing (he/him) Senior Software Engineer (Images) Business Systems and Applications Broadcast & End-User Technology (BEUT) BBC Technology Group

From: Mateusz @.> Reply to: guardian/grid @.> Date: Thursday, 2 November 2023 at 11:00 To: guardian/grid @.> Cc: Andrew Downing @.>, Author @.***> Subject: Re: [guardian/grid] Change upload description control to have non-funny prompt (PR #4180)

less likely to offend

O tempora, o mores! 😢

Sad, but fine, IMHO, so: 👍. Whatever makes people write better captions, wins.

— Reply to this email directly, view it on GitHubhttps://github.com/guardian/grid/pull/4180#issuecomment-1790510187, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6UE4XVCIY2RRWJGKOWBPV3YCN4KLAVCNFSM6AAAAAA62VYEBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGUYTAMJYG4. You are receiving this because you authored the thread.Message ID: @.***>

http://www.bbc.co.uk This e-mail (and any attachments) is confidential and may contain personal views which are not the views of the BBC unless specifically stated. If you have received it in error, please delete it from your system. Do not use, copy or disclose the information in any way nor act in reliance on it and notify the sender immediately. Please note that the BBC monitors e-mails sent or received. Further communication will signify your consent to this.

twrichards commented 8 months ago

@AndyKilmory I've just merged @abdelrahmansd 's PR #4172 so you'll need to update with main (ideally with the rebase button at the bottom of the PR)

AndyKilmory commented 8 months ago

Thanks Tom – will sort out the changes and rebase tomorrow.

Regards, Andy

Andy Downing (he/him) Senior Software Engineer (Images) Business Systems and Applications Broadcast & End-User Technology (BEUT) BBC Technology Group

From: Tom Richards @.> Reply to: guardian/grid @.> Date: Thursday, 2 November 2023 at 15:40 To: guardian/grid @.> Cc: Andrew Downing @.>, Mention @.***> Subject: Re: [guardian/grid] Change upload description control to have non-funny prompt (PR #4180)

@AndyKilmoryhttps://github.com/AndyKilmory I've just merged @abdelrahmansdhttps://github.com/abdelrahmansd 's PR #4172https://github.com/guardian/grid/pull/4172 so you'll need to update with main (ideally with the rebase button at the bottom of the PR)

— Reply to this email directly, view it on GitHubhttps://github.com/guardian/grid/pull/4180#issuecomment-1790979346, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6UE4XX3YJ4R6XHCQPU4PO3YCO5FFAVCNFSM6AAAAAA62VYEBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHE3TSMZUGY. You are receiving this because you were mentioned.Message ID: @.***>

AndyKilmory commented 8 months ago

Suggestions incorporated and rebased to main

AndyKilmory commented 8 months ago

Many thanks

Andy Downing (he/him) Senior Software Engineer (Images) Business Systems and Applications Broadcast & End-User Technology (BEUT) BBC Technology Group

From: Tom Richards @.> Reply to: guardian/grid @.> Date: Friday, 3 November 2023 at 09:42 To: guardian/grid @.> Cc: Andrew Downing @.>, Mention @.***> Subject: Re: [guardian/grid] Change upload description control to have non-funny prompt (PR #4180)

Merged #4180https://github.com/guardian/grid/pull/4180 into main.

— Reply to this email directly, view it on GitHubhttps://github.com/guardian/grid/pull/4180#event-10853521814, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6UE4XQO2B6GJNXEUNRPVYTYCS4BPAVCNFSM6AAAAAA62VYEBOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA2TGNJSGE4DCNA. You are receiving this because you were mentioned.Message ID: @.***>

prout-bot commented 8 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (created by @AndyKilmory and merged by @twrichards 8 minutes and 48 seconds ago) Please check your changes!

guardian / grid