chore: migrate AWS SDK for JavaScript v2 APIs to v3 in s3watcher/scripts

guardian / grid

The Guardian’s image management system

https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service

Apache License 2.0

1.44k stars 119 forks source link

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in s3watcher/scripts #4184

Closed trivikr closed 6 months ago

trivikr commented 8 months ago

What does this change?

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx aws-sdk-js-codemod@0.26.1 -t v2-to-v3 s3watcher/**/*.js

How should a reviewer test this change?

Verify if scripts work in s3watcher

How can success be measured?

Scripts successfully execute in s3watcher

Who should look at this?

@andrew-nowak

Tested? Documented?

[ ] locally by committer
[ ] locally by Guardian reviewer
[ ] on the Guardian's TEST environment
[ ] relevant documentation added or amended (if needed)

twrichards commented 6 months ago

Hi @trivikr - thank you so much for kindly raising this PR to migrate to use v3 SDK and huge apologies for the massive delay getting back to you. As it happens we'll be deleting s3watcher pretty soon (as a result of #4201 and subsequent PRs) and we're no longer using it at the Guardian since 2nd Jan (just waiting on another org. who have a deployment of the 'grid' to migrate to the new architecture). Would you like to close the PR, or leave it open until s3watcher is actually gone? Also happy to test the changes in our TEST environment with an eye to merging (so you can be a contributor on this wonderful project if you'd prefer)?

trivikr commented 6 months ago

Would you like to close the PR

Sure. As long as JS SDK v2 is no longer in use, this PR can be closed.