search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 119 forks source link

configurable default on/off for 'graphic image' blurring (with tooltip/explainer which must be acknowledged) #4187

Closed twrichards closed 8 months ago

twrichards commented 8 months ago

Although we've proved out the value of #4174 (opt-in), usage remains fairly low (around 5%) - so this PR makes the default configurable.

If configured (defaultShouldBlurGraphicImages = true in common.conf), for users who've not yet used the feature (i.e. no SHOULD_BLUR_GRAPHIC_IMAGES cookie) then we now present a modal/overlay explaining the feature and the fact its on by default - which must be acknowledged (sets the cookie value to "true") OR can be turned off via the tickbox (sets the cookie value to "false")...

image

Also includes refactor of all 'graphic image' blurring logic into its own Angular 'service'.

bryophyta commented 8 months ago

This looks like a great feature!

I haven't run the Grid locally before so not been able to test this yet, but I noticed that the checkbox is outside the modal in the screenshot, so just wanted to check whether this feature has been tested for keyboard-only navigation?

twrichards commented 8 months ago

This looks like a great feature!

I haven't run the Grid locally before so not been able to test this yet, but I noticed that the checkbox is outside the modal in the screenshot, so just wanted to check whether this feature has been tested for keyboard-only navigation?

Great point @bryophyta - it is indeed keyboard navigable, but your prompt made me check and the keyboard navigation still goes to the inputs beneath the modal/overlay first - I'll see if I can sort that out now

bryophyta commented 8 months ago

Great point @bryophyta - it is indeed keyboard navigable, but your prompt made me check and the keyboard navigation still goes to the inputs beneath the modal/overlay first - I'll see if I can sort that out now

Thanks for taking a look! Yeah, modals can v fiddly; hope you can find a solution without too much hassle!

prout-bot commented 8 months ago

Overdue on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 30 minutes and 3 seconds ago) What's gone wrong?

prout-bot commented 8 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 33 minutes and 20 seconds ago) Please check your changes!