search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 119 forks source link

FIX `acceptDefaultOfBlurringGraphicImages` #4188

Closed twrichards closed 8 months ago

twrichards commented 8 months ago

tiny fix to #4187 so that when navigating round the SPA (e.g. clicking on an image) user is not re-prompted with pop-up

twrichards commented 8 months ago

Looks good to me! (Could have sworn I'd seen that in the original PR?)

there was already a reload for when changing the cookie to a different value, but I had originally wanted to avoid the reload when accepting the default, since it was already applying blurring. using a reload to fix this is quite blunt, just wanna get a fix out then see if I can refine after

Georges-GNM commented 8 months ago

Looks good to me! (Could have sworn I'd seen that in the original PR?)

there was already a reload for when changing the cookie to a different value, but I had originally wanted to avoid the reload when accepting the default, since it was already applying blurring. using a reload to fix this is quite blunt, just wanna get a fix out then see if I can refine after

Ah yeah, just had a look to check where the reload was set in the first one. Maybe blunt sure, but it'll do for now!

twrichards commented 8 months ago

Looks good to me! (Could have sworn I'd seen that in the original PR?)

there was already a reload for when changing the cookie to a different value, but I had originally wanted to avoid the reload when accepting the default, since it was already applying blurring. using a reload to fix this is quite blunt, just wanna get a fix out then see if I can refine after

Ah yeah, just had a look to check where the reload was set in the first one. Maybe blunt sure, but it'll do for now!

Given angular services don't support two way binding without adding heaps of extra watch logic which is brittle - I'm going to stick with this approach as its not frequently used functionality.

prout-bot commented 8 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @twrichards 8 minutes and 45 seconds ago) Please check your changes!