search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.44k stars 119 forks source link

URI encode the filename in transit through the queue-based mechanism to ensure it handles diacritics etc. #4221

Closed twrichards closed 6 months ago

twrichards commented 6 months ago

Small tweak following #4201 to ensure we can handle diacritics in filenames uploaded from UI (FTP is unaffected AFAICT) as they pass through S3 metadata.

One could argue instead we use the filename in S3 for filename, and a new metadata header for media id to avoid this 🤔 EDIT: we did go this way in the end in https://github.com/guardian/grid/pull/4222

github-actions[bot] commented 6 months ago

Deploy build 12218 to TEST

All deployment options - [Deploy build 12218 to TEST](https://riffraff.gutools.co.uk/deployment/deployAgain?project=media-service%3A%3Agrid%3A%3Aall&build=12218&stage=TEST&updateStrategy=MostlyHarmless&action=deploy) - [Deploy parts of build 12218 to TEST by previewing it first](https://riffraff.gutools.co.uk/preview/yaml?project=media-service%3A%3Agrid%3A%3Aall&build=12218&stage=TEST&updateStrategy=MostlyHarmless)

From guardian/actions-riff-raff.

twrichards commented 6 months ago

Closing in favour of approach in https://github.com/guardian/grid/pull/4222 which is generally better