guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.43k stars 119 forks source link

Conal/imagedam 1502 send to capture handle user input #4254

Closed Conalb97 closed 1 month ago

Conalb97 commented 3 months ago

What does this change?

As an archivist user of BBC Images, I want to be able to send certain images from BBC Images to BBC Photo Sales, through the Grid UI. This PR introduces this functionality, allowing a user to select a number of images and trigger the outbound photo sales process by clicking on the new 'Send to Photo Sales' button. By doing this, a syndication usage (with a 'pending' usage status) is added to each of the selected image, which is the trigger for an AWS step function that carries out the majority of the outbound logic.

This PR is only concerned with the ability of a user to select images and add a syndication usage through the frontend, future PRs will handle additional features such as confirmation dialogs, restrictions on what images can be sent, success/failure notifications and changes to the metadata panel.

As this is BBC specific functionality, it is disabled by default via the showSendToPhotoSales feature flag.

Screenshot 2024-03-20 at 16 56 07

Note: this PR has been developed on top of the changes introduced in https://github.com/guardian/grid/pull/4244, which is still to be merged. As such there are additional files inlcuded in the PR that are outside its scope. The only files that need to be reviewed as part of this PR are:

How should a reviewer test this change?

As a user with elevated permissions and with the showSendToPhotoSales flag set to true:

How can success be measured?

Who should look at this?

@guardian/digital-cms

Tested? Documented?

AndyKilmory commented 3 months ago

Could amend dev/script/generate-config/service-config.js to provide value for the show/hide flag. Other than the js syntax errors flagged up by CI checks all looks okay.

AndyKilmory commented 3 months ago

Minor comment added - see above - but all looks okay to me.

paperboyo commented 1 month ago

Just for future travellers: closed in favour of https://github.com/guardian/grid/pull/4267.