search

guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.43k stars 119 forks source link

modifications to correct bug linked to clean cookie operation #4264

Closed AndyKilmory closed 2 months ago

AndyKilmory commented 2 months ago

What does this change?

Code changes introduced to simplfy the getCookie operation within the notification banner introduced a bug linked to the clean cookie operation ran on initialisation which removes obselete notification/announcement ids from the cookie to stop it bloating over time. It incorrectly cleared some ids from the cookie. The change simply corrects this problem

How should a reviewer test this change?

Ensure that once acknowledged announcements stay 'hidden' after browser refresh (refresh at least twice to be sure bug is not present)

Who should look at this?

Tested? Documented?

prout-bot commented 2 months ago

Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (created by @AndyKilmory and merged by @rebecca-thompson 9 minutes and 39 seconds ago) Please check your changes!