guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.43k stars 119 forks source link

t1720 - basic configurable labels for sortControl #4273

Closed AndyKilmory closed 1 month ago

AndyKilmory commented 1 month ago

What does this change?

This change allows an organisation to customise the labels seen on the sort control (an provides a pattern for general label customisation).

It uses the strings.json to hold the label overrides. The key for the entry in strings.json takes the form "<>_<

"gr-sort-control_oldest": "Upload - oldest first"

If there isn't a key matching the format required in strings.json then the default label is used.

How should a reviewer test this change?

Ensure that when an appropriate configured entry is added to string.json it appears correctly in the UI for the sort control.

Who should look at this?

Tested? Documented?