guardian / grid

The Guardian’s image management system
https://www.theguardian.com/info/developer-blog/2015/aug/12/open-sourcing-grid-image-service
Apache License 2.0
1.43k stars 119 forks source link

Remove unused Thrall MetadataEditorNotifications. #4277

Closed tonytw1 closed 1 month ago

tonytw1 commented 1 month ago

What does this change?

Drops mandatory but unused thrall config element indexed.image.sns.topic.arn

This in turn means you don't need to provision this SNS queue, which is one less piece of infrastructure to build when adopting the grid.

How should a reviewer test this change?

How can success be measured?

No visible effects because the code does not appear to be pushing messages onto this queue. Opportunity to remove a piece of infrastructure.

Who should look at this?

Tested? Documented?

tonytw1 commented 1 month ago

Closing; a stand alone Grid doesn't need this SNS topic because nothing else in the Grid listens for it BUT their is probably something at the Guardian that IS listening.